Configure asset metadata #659
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangeross
force-pushed
the
savage-asset-metadata
branch
from
e6a24e3 to
2e0d015
Compare
|
I have to admit at first I thought we should provide a larger list of assets but this minimal approach is more appealing now. |
|
Yes |
roeierez
reviewed
Jan 15, 2025
| use super::{AssetMetadata, Persister}; | ||
|
|
||
| impl Persister { | ||
| pub(crate) fn replace_asset_metadata( |
There was a problem hiding this comment.
Can you elaborate what is the advantage of persisting the configurable assets?
There was a problem hiding this comment.
For rendering the payment list, it seems simpler to add them to the SQL join
lib/core/src/model.rs
Outdated
Comment on lines
1488
to
1487
| impl AssetMetadata { | ||
| pub fn to_sat(&self, amount: f64) -> u64 { | ||
| (amount * (10_u64.pow(self.precision) as f64)) as u64 | ||
| } | ||
|
|
||
| pub fn from_sat(&self, amount_sat: u64) -> f64 { | ||
| amount_sat as f64 / (10_u64.pow(self.precision) as f64) | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: this is a bit unconventional. Maybe we could have an AssetAmount struct with these methods.
dangeross
force-pushed
the
savage-multi-assets
branch
2 times, most recently
from
36f9697 to
289d61f
Compare
dangeross
force-pushed
the
savage-asset-metadata
branch
2 times, most recently
from
dbc649c to
e01ea48
Compare
dangeross
force-pushed
the
savage-multi-assets
branch
from
289d61f to
4dfef3b
Compare
dangeross
force-pushed
the
savage-asset-metadata
branch
from
e01ea48 to
2e7501a
Compare
roeierez
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on PR #645
This PR:
Depends on breez/breez-sdk-greenlight#1157