Add support for paying to BOLT12 #549

ok300 · 2024-11-06T19:41:21Z

This PR adds support for paying to a BOLT12 offer.

The flow is as follows:

user specifies a BOLT12 offer destination when paying
SDK calls Boltz endpoint that fetches a BOLT12 invoice for given offer
SDK calls send_payment_via_swap with the BOLT12 invoice as argument, instead of the usual BOLT11

Open questions

Should we also support paying directly to BOLT12 invoices, in addition to BOLT12 offers?
Expand PaymentDetails::Lightning with a new field for bolt12_invoice? And / or an optional bolt12_offer?
- Or alternatively rename the existing bolt11 field to invoice, so it means either BOLT11 or BOLT12 invoice?
Should we fetch the invoice during prepare? This may take a long time for slow endpoints (Phoenix), causing the user to wait a few seconds for prepare to return.
Update sdk_common::input_parser to parse BOLT12 offers / invoice? Or keep changes local to the Liquid SDK?
- Use BIP-353 "DNS Payment Instructions" for BOLT12 resolution? (similar to LN Address)

Open TODOs

Validate returned invoice (check signature) before trying to pay it
~~Detect / handle MRH in BOLT12 invoices~~
Handle both BOLT11 and BOLT12 in persister
When paying to a bolt12 offer, list_payments shows payments as Pending
When paying to a bolt12 offer, list_payments shows the bolt12 invoice under bolt11 (should show offer instead)

lib/core/src/sdk.rs

lib/core/src/persist/mod.rs

lib/core/src/sdk.rs

Co-authored-by: Ross Savage <[email protected]>

# Conflicts: # cli/src/commands.rs # lib/core/src/sdk.rs

Don't try to extract invoice description, because it is added later during persist.

dangeross

Looking good

cli/src/commands.rs

lib/core/src/sdk.rs

Co-authored-by: Ross Savage <[email protected]>

MRH with Bolt12 is not possible because receive is not yet supported.

Removed self-transfer check TODO, because self-transfers are not possible with Bolt12 when receive is not supported.

lib/core/src/sdk.rs

lib/core/src/persist/migrations.rs

lib/core/src/persist/mod.rs

lib/bindings/src/breez_sdk_liquid.udl

roeierez

Other than @dangeross comments I think it looks good!

erdemyerebasmaz · 2024-11-19T06:41:24Z

Dart changes look good

dangeross

LGTM

* commit '02dd93c810226d2c38d71c959cf26e695084f839': Add preimage to receive payment (#571) Add support for paying to BOLT12 (#549) Fix swift URL init compatibility (#569) Configurable cache dir (#567) Android: Replaced with (#558)

This reverts commit fe1dc30

Add initial version of paying to a BOLT12 offer

1e1a00d

ok300 requested review from roeierez and dangeross November 6, 2024 19:41

roeierez requested changes Nov 6, 2024

View reviewed changes

lib/core/src/sdk.rs Outdated Show resolved Hide resolved

lib/core/src/sdk.rs Outdated Show resolved Hide resolved

lib/core/src/sdk.rs Outdated Show resolved Hide resolved

ok300 added 4 commits November 10, 2024 14:44

Bump sdk-common

06e6529

SendDestination: Bolt12 type stores amount in addition to offer

f4d6a3b

prepare_send_payment: remove fetching Bolt12 invoice

5521b1e

Re-generate RN bindings

8244e1c

dangeross reviewed Nov 12, 2024

View reviewed changes

lib/core/src/persist/mod.rs Outdated Show resolved Hide resolved

lib/core/src/sdk.rs Outdated Show resolved Hide resolved

lib/core/src/sdk.rs Outdated Show resolved Hide resolved

ok300 and others added 11 commits November 13, 2024 10:13

Bump sdk-common with new Bolt12Offer(String)

e76c8f9

Update lib/core/src/sdk.rs

47841e4

Co-authored-by: Ross Savage <[email protected]>

Merge branch 'main' into ok300-add-bolt12

96a12b2

# Conflicts: # cli/src/commands.rs # lib/core/src/sdk.rs

Re-generate RN bindings

f5839e6

Fix tests

68449c2

Address invoice description persistence

790d8f2

Don't try to extract invoice description, because it is added later during persist.

Bump sdk-common to use new InputType variant

0219b99

Cargo fmt

690e2e6

Bump sdk-common to include fixed type reference

43a0bfe

Update SendDestination::Bolt12 to include LNOffer

bb18d10

Re-generate RN bindings

4a53177

dangeross reviewed Nov 13, 2024

View reviewed changes

cli/src/commands.rs Outdated Show resolved Hide resolved

lib/core/src/sdk.rs Show resolved Hide resolved

lib/core/src/sdk.rs Outdated Show resolved Hide resolved

ok300 and others added 8 commits November 14, 2024 09:09

Bump sdk-common, propagate changes

2928ed9

Update cli/src/commands.rs

f9b9d54

Co-authored-by: Ross Savage <[email protected]>

Bump sdk-common, propagate changes

10fbefa

Clarify CLI invoice description

9ae1f6c

Address MRH TODO

83ccce0

MRH with Bolt12 is not possible because receive is not yet supported.

Address self-transfer TODO

b54da49

Removed self-transfer check TODO, because self-transfers are not possible with Bolt12 when receive is not supported.

Add Bolt12 invoice validation before paying

6be99de

Extract Bolt12 invoice validation to own method

ead0438

dangeross reviewed Nov 18, 2024

View reviewed changes

lib/core/src/sdk.rs Outdated Show resolved Hide resolved

ok300 added 2 commits November 18, 2024 12:20

Persist bolt12_offer in DB

2423180

prepare_send_payment: validate user chosen amount

9920648

ok300 force-pushed the ok300-add-bolt12 branch from a3477b4 to 9920648 Compare November 18, 2024 11:26

ok300 marked this pull request as ready for review November 18, 2024 11:26

ok300 added 2 commits November 18, 2024 12:32

boltz-client: switch to latest upstream

380f2a1

verify_payment_hash: handle bolt11 and bolt12 invoices

c069f99

dangeross reviewed Nov 18, 2024

View reviewed changes

lib/core/src/persist/migrations.rs Outdated Show resolved Hide resolved

lib/core/src/persist/mod.rs Show resolved Hide resolved

lib/bindings/src/breez_sdk_liquid.udl Show resolved Hide resolved

lib/bindings/src/breez_sdk_liquid.udl Show resolved Hide resolved

Rename LNOfferBlindedPath to LnOfferBlindedPath

eec205e

roeierez approved these changes Nov 18, 2024

View reviewed changes

ok300 added 4 commits November 19, 2024 12:33

Update notification plugin

290e04e

Simplify migration

13ebcfe

Bump sdk-common

7124f6d

When sending to Bolt12 offers, treat the offer as destination

81eeb66

dangeross approved these changes Nov 19, 2024

View reviewed changes

ok300 merged commit fe1dc30 into main Nov 19, 2024
8 checks passed

ok300 mentioned this pull request Nov 19, 2024

Consolidate Bolt12 parsing into sdk-common #573

Open

4 tasks

ok300 added a commit that referenced this pull request Nov 19, 2024

Revert "Add support for paying to BOLT12 (#549)"

6bbcb0b

This reverts commit fe1dc30

ok300 mentioned this pull request Nov 19, 2024

Revert "Add support for paying to BOLT12 (#549)" #574

Closed

erdemyerebasmaz mentioned this pull request Nov 20, 2024

Add support for paying BOLT12 offers breez/misty-breez#248

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for paying to BOLT12 #549

Add support for paying to BOLT12 #549

ok300 commented Nov 6, 2024 •

edited

Loading

dangeross left a comment

roeierez left a comment

erdemyerebasmaz commented Nov 19, 2024

dangeross left a comment

Add support for paying to BOLT12 #549

Add support for paying to BOLT12 #549

Conversation

ok300 commented Nov 6, 2024 • edited Loading

dangeross left a comment

Choose a reason for hiding this comment

roeierez left a comment

Choose a reason for hiding this comment

erdemyerebasmaz commented Nov 19, 2024

dangeross left a comment

Choose a reason for hiding this comment

ok300 commented Nov 6, 2024 •

edited

Loading