Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Wallet) Fix Dapps dialog not dismissed when creating a new tab #27249

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

simoarpe
Copy link
Collaborator

Resolves brave/brave-browser#43167

Fixes an issue where Dapps dialog was not properly dismissed when creating a new tap from homescreen shortcut.

Demo

Screen.Recording.2025-01-15.at.5.39.05.PM.mov

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Visit https://kjozwiak.github.io/crash.html
  • Unlock Brave Wallet if requested
  • Observe the Dapp connection dialog shows up
  • Background the app
  • Long press on icon and select New Tab
  • Observe the Dapp connection dialog not showing up

@simoarpe simoarpe added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Jan 15, 2025
@simoarpe simoarpe self-assigned this Jan 15, 2025
@simoarpe simoarpe requested a review from deeppandya as a code owner January 15, 2025 16:43
Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@simoarpe simoarpe merged commit f4d205a into master Jan 15, 2025
19 checks passed
@simoarpe simoarpe deleted the simone/fix-dapps-dialog-dismiss branch January 15, 2025 18:31
@github-actions github-actions bot added this to the 1.76.x - Nightly milestone Jan 15, 2025
@brave-builds
Copy link
Collaborator

Released in v1.76.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect popup is not dismissed when opening a new tab from home screen
4 participants