Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid closing connections on first party storage cleanup. (uplift to 1.74.x) #27189

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Avoid closing connections on first party storage cleanup. (uplift to 1.74.x) #27189

merged 1 commit into from
Jan 13, 2025

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jan 10, 2025 •
edited by LaurenWags
Loading

Uplift of #27095
Resolves brave/brave-browser#39570

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner January 10, 2025 11:30
@brave-builds brave-builds requested a review from a team January 10, 2025 11:30
@brave-builds brave-builds added this to the 1.74.x - Release milestone Jan 10, 2025
@brave-builds brave-builds self-assigned this Jan 10, 2025
LaurenWags
LaurenWags approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.74.x is approved 👍🏻 Associated issue is QA/No, so no manual QA verification was completed.

@LaurenWags LaurenWags merged commit e12960c into 1.74.x Jan 13, 2025
17 checks passed
@LaurenWags LaurenWags deleted the pr27095_issues/39570_1.74.x branch January 13, 2025 15:26
@brave-builds
Copy link
Collaborator Author

Released in v1.74.47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags LaurenWags approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.74.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @LaurenWags