Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't need to have rounded contents margin in tab-fullscreen #27150

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jan 8, 2025

fix brave/brave-browser#43136

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See the linked issue.

@simonhong simonhong self-assigned this Jan 8, 2025
@simonhong simonhong marked this pull request as ready for review January 8, 2025 03:45
@simonhong simonhong merged commit 2a00b6d into master Jan 8, 2025
19 checks passed
@simonhong simonhong deleted the contents_margin_for_rounded_corners branch January 8, 2025 22:49
@github-actions github-actions bot added this to the 1.76.x - Nightly milestone Jan 8, 2025
brave-builds added a commit that referenced this pull request Jan 8, 2025
brave-builds added a commit that referenced this pull request Jan 8, 2025
@brave-builds
Copy link
Collaborator

Released in v1.76.1

@kjozwiak
Copy link
Member

kjozwiak commented Jan 9, 2025

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.76.1 Chromium: 132.0.6834.57 (Official Build) nightly (64-bit)
-- | --
Revision | 3140cfb88368b97c98ca36647dd22dc123ff2430
OS | Windows 11 Version 24H2 (Build 26100.2605)
JavaScript | V8 13.2.152.23

I've personally had this issue for ~2-3 months where thin white borders were appearing at the side of the monitor whenever watching any type of media in full screen. Updated my personal profile and ensured the browser border has been removed when watching YT or Netflix. Asked @okidokiokami to check/verify as well.

Broken Fixed
Screenshot 2025-01-08 203725 Screenshot 2025-01-09 012804

kjozwiak pushed a commit that referenced this pull request Jan 9, 2025
kjozwiak pushed a commit that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show browser border when tab fullscreen mode is on
4 participants