Fix UNSAFE_TODO for wallet [part 2 of N]

[supermassive]

Resolves brave/brave-browser#42200

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

[cdesouza-chromium]

LGTM

[darkdh]

Suggested change

	auto array_type = type_split[0];
	const auto array_type = type_split[0];

just a nit for it to be const std::string_view

[github-actions]

[puLL-Merge] - brave/brave-core@26469

Description

This PR makes several changes to improve code quality, safety, and performance in the Brave Wallet component. The changes primarily focus on modernizing C++ usage, improving type safety, and optimizing memory operations.

Changes

Changes

1. components/brave_wallet/browser/eip1559_transaction.cc and eip2930_transaction.cc:

   • Added #include "base/containers/to_vector.h"
   • Changed KeccakHash(result) to base::ToVector(KeccakHash(result))

2. components/brave_wallet/browser/eth_abi_decoder.cc:

   • Removed #pragma allow_unsafe_buffers
   • Added #include "base/containers/span_reader.h"
   • Replaced several raw pointer and size-based operations with base::span and base::SpanReader
   • Optimized string operations using base::StrCat

3. components/brave_wallet/browser/eth_abi_decoder.h:

   • Changed function signature to use base::span<const uint8_t> instead of const std::vector<uint8_t>&

4. components/brave_wallet/browser/eth_allowance_manager.cc:

   • Changed KeccakHash usage to return a hex string directly

5. components/brave_wallet/browser/eth_data_parser.cc:

   • Replaced vector slicing with base::span operations

6. components/brave_wallet/browser/eth_transaction.cc:

   • Added #include "base/containers/to_vector.h"
   • Changed KeccakHash usage to return byte arrays instead of strings

7. components/brave_wallet/browser/ethereum_keyring.cc:

   • Optimized string and vector operations using base::StrCat and base::Extend

8. components/brave_wallet/browser/ethereum_provider_impl.cc:

   • Added #include "base/containers/to_vector.h"
   • Changed std::move(message_to_sign) to base::ToVector(message_to_sign)

9. components/brave_wallet/browser/internal/hd_key.cc:

   • Optimized memory operations using base::span and base::ToVector

10. components/brave_wallet/common/eth_address.cc and eth_address.h:

    • Replaced raw pointer operations with base::span
    • Optimized string operations using base::StrCat

11. components/brave_wallet/common/eth_sign_typed_data_helper.cc and eth_sign_typed_data_helper.h:

    • Replaced std::vector<uint8_t> with custom Eip712HashArray type
    • Optimized string operations and memory usage

12. components/brave_wallet/common/hash_utils.cc and hash_utils.h:

    • Introduced new types like KeccakHashArray and Ripemd160HashArray
    • Optimized hash functions to work with base::span

13. components/brave_wallet/common/hex_utils.cc and hex_utils.h:

    • Removed redundant function overloads
    • Standardized on base::span for input parameters

14. components/brave_wallet/common/zcash_utils.cc:

    • Optimized memory operations using base::span and base::Extend

Possible Issues

• The changes to function signatures and return types may require updates in calling code not visible in this diff.
• Some optimizations might affect performance in unexpected ways and should be benchmarked.

Security Hotspots

No significant security issues were identified in this change. The modifications generally improve type safety and reduce the risk of buffer overflows or misuse of raw pointers.

[brave-builds]

Released in v1.75.27