Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Fix tx submission screen gets dismissed automatically after tx is confirmed #25957

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix(wallet): Fix tx submission screen gets dismissed automatically after tx is confirmed #25957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ios/brave-ios/Sources/BraveWallet/Crypto/Stores/CryptoStore.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ public class CryptoStore: ObservableObject, WalletObserverStore {
@Published var isPresentingPendingRequest: Bool = false {
didSet {
if !isPresentingPendingRequest {
confirmationStore = nil
closeConfirmationStore()
closeSignMessageRequestStore()
}
}
}
Expand Down
6 changes: 0 additions & 6 deletions ios/brave-ios/Sources/BraveWallet/Panels/RequestContainerView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,5 @@ struct RequestContainerView<DismissContent: ToolbarContent>: View {
}
}
.navigationViewStyle(.stack)
.onDisappear {
// `onDisappear` on individual views will trigger for navigation pushes.
// Close stores when navigation covers manual dismiss & onDismiss() cases.
cryptoStore.closeConfirmationStore()
cryptoStore.closeSignMessageRequestStore()
}
}
}
Loading