Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Inactive tabs setting to Appearance section (uplift to 1.72.x) #25924

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Move Inactive tabs setting to Appearance section (uplift to 1.72.x) #25924

merged 2 commits into from
Oct 14, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Oct 10, 2024 •
edited by LaurenWags
Loading

Uplift of #25907
Resolves brave/brave-browser#41482

Uplift of #25952
Resolves brave/brave-browser#41576

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner October 10, 2024 13:47
@brave-builds brave-builds added this to the 1.72.x - Beta milestone Oct 10, 2024
@brave-builds brave-builds self-assigned this Oct 10, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 10, 2024
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

@LaurenWags
Copy link
Member

Adding Uplift/Blocked per discussion via https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1728568063554079 as we'll wait for the changes from #25952 to be added to this uplift.

@emerick
Merge pull request #25952 from brave/cr130-followup-fix-inactive-tabs…
6a017bb 
…-setting-placement

Fix placement of inactive tabs setting
@LaurenWags
Copy link
Member

Removing Uplift/Blocked since #25952 has been added to this uplift and verified

LaurenWags
LaurenWags approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.72.x is approved 👍🏻 QA has verified the PR using 1.73.x/Nightly as per #25907 (comment) and #25952 (comment).

@LaurenWags LaurenWags merged commit 8f9b1ea into 1.72.x Oct 14, 2024
15 checks passed
@LaurenWags LaurenWags deleted the pr25907_emerick-move-inactive-tab-setting-to-appearance-section_1.72.x branch October 14, 2024 13:22
@brave-builds
Copy link
Collaborator Author

Released in v1.72.80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags LaurenWags approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.73.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @LaurenWags @emerick