[ads] Followup to "Send HTTP response status for landed events as part of the confirmation token redemption" #36752

[tmancey]

Resolves brave/brave-browser#40991

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

Verify that the HTTP response status codes 400, 401, 403, 404, 407, 408, 429, 451, 500, 502, 503, and 504 are included in the confirmation token redemption payload as "httpResponseStatus": "###" for Rewards users (e.g., "httpResponseStatus": "503"). For any unlisted status codes, the response should only reflect the status code class (e.g., 1xx, 2xx, 3xx, 4xx, 5xx). The "httpResponseStatus" key should NOT be included for non-Rewards users.

[tmancey]

Privacy review discussion https://github.com/brave/reviews/issues/1553, thanks. cc @fmarier

[boocmp]

This one is used only in DidFinishNavigation if I'm right. I'd prefer to remove such a context dependent method in favor of the lambda function in DidFinishNavigation

[tmancey]

Thanks. We have a comment in the header:

  // NOTE: DO NOT use this method before the navigation commit as it will return
  // null. It is safe to use from `WebContentsObserver::DidFinishNavigation()`.
  std::optional<int> HttpStatusCode(

[ShivanKaul]

privacy lgtm

[fmarier]

nit: Is this needed?

Suggested change

///////////////////////////////////////////////////////////////////////////////

[tmancey]

@fmarier this is expected because I break up public/private sections using this divider. Thanks

[brave-builds]

Released in v1.73.14