Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Search Suggestions Enhancement (uplift to 1.70.x) #25150

Closed
wants to merge 1 commit into from
Closed

[iOS] Search Suggestions Enhancement (uplift to 1.70.x) #25150

wants to merge 1 commit into from

Conversation

soner-yuksel
Copy link
Contributor

Uplift of #24376
Resolves brave/brave-browser#38137

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@soner-yuksel soner-yuksel added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Aug 15, 2024
@soner-yuksel soner-yuksel added this to the 1.70.x - Beta milestone Aug 15, 2024
@soner-yuksel soner-yuksel self-assigned this Aug 15, 2024
@soner-yuksel soner-yuksel requested a review from a team as a code owner August 15, 2024 16:30
kjozwiak
kjozwiak reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing as discussed with @jamesmudgett via https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1723739984640469. We'll this one ride the trains via 1.71.x.

@kjozwiak kjozwiak closed this Aug 27, 2024
@kjozwiak kjozwiak deleted the pr24376_ios_search_suggestions_1.70.x branch August 27, 2024 18:27
@kjozwiak kjozwiak removed this from the 1.70.x - Beta milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak left review comments

Assignees

@soner-yuksel soner-yuksel

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soner-yuksel @kjozwiak