Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated history page's item font style #24646

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Updated history page's item font style #24646

merged 1 commit into from
Jul 15, 2024

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jul 15, 2024

fix brave/brave-browser#39722

Use 13px, 400 for font-size and weight.

Screenshot 2024-07-15 161117

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See the linked issue

@simonhong simonhong self-assigned this Jul 15, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jul 15, 2024
@simonhong simonhong force-pushed the history_item_font branch from acc1b6d to d5c4f19 Compare July 15, 2024 07:18
@simonhong simonhong force-pushed the history_item_font branch from d5c4f19 to 17a322d Compare July 15, 2024 07:51
@simonhong simonhong marked this pull request as ready for review July 15, 2024 08:27
@simonhong simonhong requested a review from sangwoo108 July 15, 2024 08:27
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhong simonhong merged commit 59efc0c into master Jul 15, 2024
16 checks passed
@simonhong simonhong deleted the history_item_font branch July 15, 2024 22:37
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jul 15, 2024
brave-builds added a commit that referenced this pull request Jul 15, 2024
@stephendonner
Copy link
Contributor

stephendonner commented Jul 16, 2024

Verification PASSED using

Brave | 1.69.109 Chromium: 127.0.6533.43 (Official Build) nightly (64-bit)
-- | --
Revision | 78e3747676cbea7118b45b18d1dfe36d90f4180c
OS | Windows 10 Version 22H2 (Build 19045.4651)

Steps:

  1. installed 1.69.109
  2. launched Brave
  3. generated/imported history items
  4. loaded brave://history
  5. opened Developer Tools
  6. clicked on Select an element in a page to inspect it
  7. hovered over a history entry
  8. looked at the CSS entries in Style

Confirmed font-size of 13px and font-weight of 400

image

kjozwiak pushed a commit that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CR 127] Font size and weight are incorrect in brave://history
4 participants