Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ads] Do not fetch geo and catalog on iOS when Brave Rewards/News disabled (uplift to 1.68.x) #24616

Merged
merged 1 commit into from
Jul 16, 2024
Merged

[ads] Do not fetch geo and catalog on iOS when Brave Rewards/News disabled (uplift to 1.68.x) #24616

merged 1 commit into from
Jul 16, 2024

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented Jul 11, 2024 •
edited by kjozwiak
Loading

Uplift of #24570
Fixes brave/brave-browser#39621

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@aseren aseren requested a review from a team as a code owner July 11, 2024 22:17
@aseren aseren added this to the 1.68.x - Beta milestone Jul 11, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@aseren
Merge pull request #24570 from brave/issues/39621
f39033a 
[ads] Do not fetch geo and catalog on iOS when Brave Rewards/News disabled
@aseren aseren force-pushed the issues/39621_1.68.x branch from dd21827 to f39033a Compare July 12, 2024 00:07
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@aseren aseren changed the title Merge pull request #24570 from brave/issues/39621 [ads] Do not fetch geo and catalog on iOS when Brave Rewards/News disabled (uplift to 1.68.x) Jul 12, 2024
kjozwiak
kjozwiak approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.68.x approved 👍 QA has verified the PR on Nightly using 1.69.x as per #24570 (comment).

@kjozwiak kjozwiak merged commit 6b613c2 into 1.68.x Jul 16, 2024
14 of 15 checks passed
@kjozwiak kjozwiak deleted the issues/39621_1.68.x branch July 16, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@aseren aseren

Labels
None yet
Projects
None yet
Milestone
1.68.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@aseren @brave-builds @kjozwiak