Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(wallet): add watch only label and alerts to unowned NFTs #24569

Merged

Conversation

josheleonard
Copy link
Contributor

@josheleonard josheleonard commented Jul 9, 2024

Resolves brave/brave-browser#39652
Resolves brave/brave-browser#39653

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Add an NFT that is not owned by one of you accounts to the assets list view the "Add NFT form"
  • View the NFT details screen (ensure that "hide unowned NFTS is unchecked)
  • The NFT in the portfolio grid should have a "Watch Only" label
  • Click the NFT
  • The NFT details screen should display an info-alert explaining that the NFT is not owned by any of the user's accounts

Screenshot 2024-07-09 at 1 32 59 PM

Screenshot 2024-07-09 at 1 33 11 PM

@josheleonard josheleonard requested review from a team as code owners July 9, 2024 19:35
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Jul 9, 2024
@josheleonard josheleonard changed the title Feat wallet add watch only label to unowned nfts Feat(wallet): add watch only label and alerts to unowned NFTs Jul 9, 2024
@josheleonard josheleonard force-pushed the feat--wallet--add-watch-only-label-to-unowned-nfts branch from 695ebe0 to 31a4ff2 Compare July 9, 2024 20:08
Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard enabled auto-merge (squash) July 9, 2024 22:24
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core++

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

@josheleonard josheleonard merged commit b0e0733 into master Jul 10, 2024
19 checks passed
@josheleonard josheleonard deleted the feat--wallet--add-watch-only-label-to-unowned-nfts branch July 10, 2024 17:56
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
5 participants