Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHECK on feature overrides reserve limit in non-component builds #24565

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

goodov
Copy link
Member

@goodov goodov commented Jul 9, 2024

This check is not reliable in Component builds, because some features are declared in source_set without proper export semantic.

Resolves brave/brave-browser#39635

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov changed the title Check on feature overrides reserve overload. CHECK on feature overrides reserve overload. Jul 9, 2024
@goodov goodov force-pushed the check_overrides_count branch from 21c23f4 to 97ed78d Compare July 9, 2024 08:50
@goodov goodov changed the title CHECK on feature overrides reserve overload. CHECK on feature overrides reserve limit in non-component builds Jul 9, 2024
@goodov goodov marked this pull request as ready for review July 9, 2024 10:36
@goodov goodov requested a review from a team as a code owner July 9, 2024 10:36
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@goodov goodov merged commit 85172e8 into master Jul 9, 2024
20 checks passed
@goodov goodov deleted the check_overrides_count branch July 9, 2024 15:00
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check on feature overrides reserve overload
2 participants