Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow default build config to be set via .env. #24564

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

goodov
Copy link
Member

@goodov goodov commented Jul 9, 2024

Resolves brave/brave-browser#39634

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov added the CI/skip Do not run CI builds (except noplatform) label Jul 9, 2024
@goodov goodov self-assigned this Jul 9, 2024
@goodov goodov added the CI/run-teamcity Run builds in TeamCity label Jul 9, 2024
@goodov goodov marked this pull request as ready for review July 9, 2024 08:13
@goodov goodov requested a review from a team as a code owner July 9, 2024 08:13
@goodov goodov enabled auto-merge (squash) July 9, 2024 08:13
@goodov goodov merged commit 642619f into master Jul 9, 2024
21 checks passed
@goodov goodov deleted the default_build_config branch July 9, 2024 09:31
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-teamcity Run builds in TeamCity CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow default build config to be set via .env
2 participants