Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AIChat): Update input box to match design tweaks #24504

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

StephenHeaps
Copy link
Collaborator

@StephenHeaps StephenHeaps commented Jul 4, 2024

  • Bump brave/leo-sf-symbols library (iOS Leo icons) to latest commit for leo.send.filled icon.
  • Tweak input area UI
  • Update searched icon image

Resolves brave/brave-browser#38960

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open Leo and verify microphone on left, disabled send button
  2. Enter some text, verify send button is now filled with colour
  3. Start a new chat and get Leo to respond with search query view to see updated icon
Leo no input Leo with input Leo search query

@StephenHeaps StephenHeaps added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Jul 4, 2024
@StephenHeaps StephenHeaps requested a review from Brandon-T July 4, 2024 12:41
@StephenHeaps StephenHeaps self-assigned this Jul 4, 2024
@StephenHeaps StephenHeaps requested review from a team as code owners July 4, 2024 12:41
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Jul 4, 2024
@StephenHeaps StephenHeaps force-pushed the ai-chat/ios-input-design-tweaks branch 2 times, most recently from ddc43aa to 353202b Compare July 4, 2024 15:35
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json changes look good

@StephenHeaps StephenHeaps force-pushed the ai-chat/ios-input-design-tweaks branch from c85febb to 49595f4 Compare July 8, 2024 18:52
@StephenHeaps StephenHeaps merged commit 1fcdd36 into master Jul 8, 2024
19 checks passed
@StephenHeaps StephenHeaps deleted the ai-chat/ios-input-design-tweaks branch July 8, 2024 20:08
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leo - Update input box to match design tweaks
3 participants