-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Open in Tor view in location bar. #24447
Conversation
c2b7dca
to
1337912
Compare
@simonhong, I think putting this action on the left of all others (as @aguscruiz proposed in brave/brave-browser#39383 (comment)) might be a bit complicated so I was thinking of leaving that out as a follow up. If you can think of an easy implementation for that, please, let me know. |
|
Thanks @simonhong, I think that looks great. 😻 I added one little simplification in 2521f39 |
eabef10
to
fef94cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
fef94cd
to
0683b81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
string reviewers ++ 😄👍
Verification INPROGRESS on
Verified the comments from #24447 (comment)
|
@mkarolin @simonhong: @rebron wants to retain logo only not text as per the slack communication https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1720472348031839?thread_ts=1720455221.114959&cid=CHGKGMHDJ |
|
* Uplift of #24447 (squashed) to beta * Merge pull request #24561 from brave/maxk-update-open-in-tor-button Updates open in Tor button. --------- Co-authored-by: Max Karolinskiy <[email protected]>
Resolves brave/brave-browser#39383
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: