Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Open in Tor view in location bar. #24447

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Jul 1, 2024

Resolves brave/brave-browser#39383

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin self-assigned this Jul 1, 2024
@mkarolin mkarolin force-pushed the maxk-update-open-in-tor-action branch from c2b7dca to 1337912 Compare July 2, 2024 17:06
@mkarolin mkarolin changed the title WIP: Updates Open in Tor view in location bar. Updates Open in Tor view in location bar. Jul 2, 2024
@mkarolin mkarolin requested a review from simonhong July 2, 2024 18:33
@mkarolin
Copy link
Collaborator Author

mkarolin commented Jul 2, 2024

@simonhong, I think putting this action on the left of all others (as @aguscruiz proposed in brave/brave-browser#39383 (comment)) might be a bit complicated so I was thinking of leaving that out as a follow up. If you can think of an easy implementation for that, please, let me know.

@simonhong
Copy link
Member

@simonhong, I think putting this action on the left of all others (as @aguscruiz proposed in brave/brave-browser#39383 (comment)) might be a bit complicated so I was thinking of leaving that out as a follow up. If you can think of an easy implementation for that, please, let me know.

Tried to set it to left most of trailing view. WDYT?
image

@mkarolin
Copy link
Collaborator Author

mkarolin commented Jul 3, 2024

Tried to set it to left most of trailing view. WDYT?

Thanks @simonhong, I think that looks great. 😻

I added one little simplification in 2521f39

@mkarolin mkarolin marked this pull request as ready for review July 3, 2024 14:42
@mkarolin mkarolin requested review from a team as code owners July 3, 2024 14:42
@mkarolin mkarolin force-pushed the maxk-update-open-in-tor-action branch from eabef10 to fef94cd Compare July 3, 2024 19:11
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@mkarolin mkarolin force-pushed the maxk-update-open-in-tor-action branch from fef94cd to 0683b81 Compare July 8, 2024 13:44
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string reviewers ++ 😄👍

@mkarolin mkarolin merged commit bb1694c into master Jul 8, 2024
19 checks passed
@mkarolin mkarolin deleted the maxk-update-open-in-tor-action branch July 8, 2024 16:10
@mkarolin mkarolin added this to the 1.69.x - Nightly milestone Jul 8, 2024
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 9, 2024

Verification INPROGRESS on

Brave | 1.69.90 Chromium: 127.0.6533.26 (Official Build) nightly (64-bit)
-- | --
Revision | f28a94aea02a03674fe24a352cb52453b6132be2
OS | Windows 10 Version 22H2 (Build 19045.4529)

Verified the comments from #24447 (comment)
Confirmed that Open in Tor button is updated as per the design on the bave.com and mail.protonmail.com

Example Example
image image
image image

@GeetaSarvadnya
Copy link

@simonhong
Copy link
Member

@mkarolin @simonhong: @rebron wants to retain logo only not text as per the slack communication https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1720472348031839?thread_ts=1720455221.114959&cid=CHGKGMHDJ

@mkarolin pushed PR for it - #24561

mkarolin pushed a commit that referenced this pull request Jul 9, 2024
kjozwiak pushed a commit that referenced this pull request Jul 10, 2024
* Uplift of #24447 (squashed) to beta

* Merge pull request #24561 from brave/maxk-update-open-in-tor-button

Updates open in Tor button.

---------

Co-authored-by: Max Karolinskiy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tor button size/spacing is small as compared to CR 126 Tor button.
5 participants