**DONT MERGE** [BraveNews] Refactor brave news's button and dialog and fix dialog not getting closed while clicking that button. #24274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
24 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
fallaciousreasoning
force-pushed
the
fix_news_button_dialog_jay
branch
from
967c6ee to
c47a0bb
Compare
getting closed while clicking that button. Basically this issue is getting fixed when we use |OnWidgetDestroyed| method of |BraveNewsBubbleView| to reset the current bubble(slower) instead of depending on |SetCloseCallback|(faster). Refer: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/views/location_bar/icon_label_bubble_view.h;l=291;drc=f2263729318bf6737e153bc27e70ab3379a789b4
…n_icon_view.cc[h]
fallaciousreasoning
force-pushed
the
fix_news_button_dialog_jay
branch
2 times, most recently
from
6e2c47a to
82317f8
Compare
|
#24226 merged so we don't need this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to run CI for #24226