Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Rust BLS implementation #11866

Merged
merged 4 commits into from
Feb 14, 2022
Merged

Use Rust BLS implementation #11866

merged 4 commits into from
Feb 14, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jan 17, 2022

Resolves brave/brave-browser#20024

  • Use Rust implementation for BLS public key calculation instead of typescript library

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Enable Filecoin feature in chrome://flags
  • export bls account key from filecoin ganache
  • import it to brave wallet
  • compare addresses in wallet and ganache, they should be same

@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Jan 17, 2022
@spylogsster spylogsster force-pushed the bls-integration branch 10 times, most recently from 8618601 to 40566b3 Compare January 18, 2022 06:43
@spylogsster spylogsster changed the title Bls integration Use Rust BLS implementation Jan 18, 2022
@spylogsster spylogsster force-pushed the bls-integration branch 3 times, most recently from 36f2a22 to df8eec9 Compare January 18, 2022 06:50
@spylogsster spylogsster force-pushed the bls-integration branch 10 times, most recently from 0fd1b61 to 29121da Compare January 18, 2022 20:08
@spylogsster spylogsster force-pushed the bls-integration branch 2 times, most recently from f2e9257 to e3efbcb Compare January 18, 2022 20:46
components/bls/rs/src/lib.rs Outdated Show resolved Hide resolved
@spylogsster spylogsster force-pushed the bls-integration branch 8 times, most recently from 13bbc0f to e258089 Compare February 8, 2022 22:55
@spylogsster spylogsster force-pushed the bls-integration branch 3 times, most recently from 0461e2b to 7a5fa5a Compare February 11, 2022 19:01
@spylogsster spylogsster force-pushed the bls-integration branch 3 times, most recently from 928690e to fe04235 Compare February 11, 2022 21:36
Copy link
Contributor

@iefremov iefremov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEPS lgtm

@spylogsster spylogsster merged commit 650c79a into master Feb 14, 2022
@spylogsster spylogsster deleted the bls-integration branch February 14, 2022 14:04
@spylogsster spylogsster added this to the 1.37.x - Nightly milestone Feb 14, 2022
@cypt4 cypt4 mentioned this pull request Apr 19, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculate BLS public key on native side
5 participants