Address P3A metric config feedback

brave · Dec 13, 2024 · fccf72d · fccf72d
1 parent 7690574
commit fccf72d
Show file tree

Hide file tree

Showing 4 changed files with 145 additions and 143 deletions.
diff --git a/components/brave_stats/browser/brave_stats_updater_util.h b/components/brave_stats/browser/brave_stats_updater_util.h
@@ -22,8 +22,10 @@ enum class ProcessArch {
 
 std::string GetDateAsYMD(const base::Time& time);
 
+// Returns platform with architecture information i.e. winx64-bc, osxarm64-bc
 std::string GetPlatformIdentifier();
 
+// Returns platform without architecture information i.e. windows, macos
 std::string GetGeneralPlatformIdentifier();
 
 int GetIsoWeekNumber(const base::Time& time);

diff --git a/components/p3a/message_manager.cc b/components/p3a/message_manager.cc
@@ -412,7 +412,7 @@ std::string MessageManager::SerializeLog(std::string_view histogram_name,
 }
 
 const std::optional<MetricConfig>* MessageManager::GetMetricConfig(
-    const std::string_view histogram_name) const {
+    std::string_view histogram_name) const {
   const std::optional<MetricConfig>* metric_config = nullptr;
 
   auto it = p3a::kCollectedTypicalHistograms.find(histogram_name);

diff --git a/components/p3a/message_manager.h b/components/p3a/message_manager.h
@@ -89,7 +89,7 @@ class MessageManager : public MetricLogStore::Delegate {
       std::optional<bool> only_update_for_constellation = std::nullopt);
 
   const std::optional<MetricConfig>* GetMetricConfig(
-      const std::string_view histogram_name) const;
+      std::string_view histogram_name) const;
 
  private:
   void StartScheduledUpload(bool is_constellation, MetricLogType log_type);