Merge pull request #24517 from brave/webcompat-version

Include browser version in webcompat reports
brave · Jul 8, 2024 · cf7f2d8 · cf7f2d8
2 parents 1fcdd36 + 3268aa9
commit cf7f2d8
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/components/webcompat_reporter/browser/BUILD.gn b/components/webcompat_reporter/browser/BUILD.gn
@@ -21,6 +21,7 @@ static_library("browser") {
     "//brave/components/brave_shields/core/common:mojom",
     "//brave/components/brave_stats/browser",
     "//brave/components/constants",
+    "//brave/components/version_info",
     "//brave/components/webcompat_reporter/buildflags",
     "//content/public/browser",
     "//net",

diff --git a/components/webcompat_reporter/browser/fields.h b/components/webcompat_reporter/browser/fields.h
@@ -18,6 +18,7 @@ inline constexpr char kLanguagesField[] = "languages";
 inline constexpr char kLanguageFarblingField[] = "languageFarblingEnabled";
 inline constexpr char kBraveVPNEnabledField[] = "braveVPNEnabled";
 inline constexpr char kChannelField[] = "channel";
+inline constexpr char kVersionField[] = "version";
 
 inline constexpr char kSiteURLField[] = "url";
 inline constexpr char kDomainField[] = "domain";

diff --git a/components/webcompat_reporter/browser/webcompat_report_uploader.cc b/components/webcompat_reporter/browser/webcompat_report_uploader.cc
@@ -11,6 +11,7 @@
 
 #include "base/json/json_writer.h"
 #include "brave/components/brave_stats/browser/brave_stats_updater_util.h"
+#include "brave/components/version_info/version_info.h"
 #include "brave/components/webcompat_reporter/browser/fields.h"
 #include "brave/components/webcompat_reporter/buildflags/buildflags.h"
 #include "content/public/browser/browser_thread.h"
@@ -58,6 +59,9 @@ void WebcompatReportUploader::SubmitReport(const Report& report) {
   report_details_dict.Set(kContactField, report.contact.Clone());
 
   report_details_dict.Set(kChannelField, report.channel);
+  report_details_dict.Set(
+      kVersionField,
+      version_info::GetBraveVersionWithoutChromiumMajorVersion());
   report_details_dict.Set(kShieldsEnabledField, report.shields_enabled);
   report_details_dict.Set(kAdBlockSettingField, report.ad_block_setting);
   report_details_dict.Set(kFPBlockSettingField, report.fp_block_setting);