code review suggestions

Signed-off-by: Vadym Struts <[email protected]>
brave · Jul 9, 2024 · 92be61e · 92be61e
1 parent 1549f5b
commit 92be61e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/browser/brave_wallet/BUILD.gn b/browser/brave_wallet/BUILD.gn
@@ -198,6 +198,7 @@ source_set("unit_tests") {
     "//chrome/browser",
     "//chrome/browser/permissions",
     "//chrome/test:test_support",
+    "//components/country_codes",
     "//testing/gtest",
   ]
   if (!is_android) {

diff --git a/browser/brave_wallet/brave_wallet_service_unittest.cc b/browser/brave_wallet/brave_wallet_service_unittest.cc
@@ -171,11 +171,6 @@ const char interface_not_supported_response[] = R"({
 
 constexpr char kBraveUrl[] = "https://brave.com";
 
-const struct {
-  const int country_code;
-  const std::string expected_country;
-} kCountryCodeCases[] = {{21843, "US"}, {17217, "CA"}, {16725, "AU"}};
-
 class MockDataRemovalObserver : public StoragePartition::DataRemovalObserver {
  public:
   explicit MockDataRemovalObserver(StoragePartition* partition) {
@@ -3074,6 +3069,11 @@ TEST_F(BraveWalletServiceUnitTest, MaybeMigrateCompressedNfts) {
 }
 
 TEST_F(BraveWalletServiceUnitTest, GetCountryCode) {
+  const struct {
+    const int country_code;
+    const std::string expected_country;
+  } kCountryCodeCases[] = {{21843, "US"}, {17217, "CA"}, {16725, "AU"}};
+
   for (const auto& [country_code, expected_country] : kCountryCodeCases) {
     GetPrefs()->SetInteger(country_codes::kCountryIDAtInstall, country_code);
     service_->GetCountryCode(base::BindLambdaForTesting(

diff --git a/components/brave_wallet/browser/BUILD.gn b/components/brave_wallet/browser/BUILD.gn
@@ -283,7 +283,7 @@ static_library("browser") {
     "//brave/third_party/argon2",
     "//components/component_updater",
     "//components/content_settings/core/browser",
-    "//components/country_codes:country_codes",
+    "//components/country_codes",
     "//components/keyed_service/core",
     "//components/prefs",
     "//components/sync_preferences",