-
Notifications
You must be signed in to change notification settings - Fork 896
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[cr133]
DetachAndAttachToNewContext
arg list reduced
This function has dropped the unnecessary two last arguments that were being provided. This has to be matched with our override of it. Chromium change: https://chromium.googlesource.com/chromium/src/+/d778cfb0a2f3ffec08056bf1db1326201e4ef82c commit d778cfb0a2f3ffec08056bf1db1326201e4ef82c Author: Taylor Bergquist <[email protected]> Date: Fri Dec 6 23:05:16 2024 +0000 Clean up TabDragController::Attach - Remove unused parameter `point_in_screen` - Remove always-true parameter `set_capture` - Split the two use cases (starting dragging and attaching to new strip) into two methods that share an impl method. They were very different! - Promote several DCHECKs to CHECKs. I commented on the CL for each explaining why I think it's safe to do w/o using NotFatalUntil. Bug: 382754501
- Loading branch information
1 parent
36ce5c0
commit 31bc91e
Showing
2 changed files
with
8 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters