Skip to content

Commit

Permalink
Merge pull request #25915 from brave/pr25912_cr130-followup-hide-medi…
Browse files Browse the repository at this point in the history
…a-control-caption-options_1.72.x

Hide caption options in media control popup (uplift to 1.72.x)
  • Loading branch information
LaurenWags authored Oct 10, 2024
2 parents 497d040 + 87eaea8 commit 186dfb9
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 1 deletion.
20 changes: 20 additions & 0 deletions chromium_src/components/live_caption/caption_util.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
/* Copyright (c) 2024 The Brave Authors. All rights reserved.
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at https://mozilla.org/MPL/2.0/. */

#include "components/live_caption/caption_util.h"

#define IsLiveCaptionFeatureSupported IsLiveCaptionFeatureSupported_ChromiumImpl

#include "src/components/live_caption/caption_util.cc"

#undef IsLiveCaptionFeatureSupported

namespace captions {

bool IsLiveCaptionFeatureSupported() {
return false;
}

} // namespace captions
1 change: 0 additions & 1 deletion test/filters/browser_tests-windows.filter
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@
-InterstitialUITest.*
-IsolatedAppBrowserServiceWorkerPushTest.ServiceWorkerPartitionedWhenWakingUpDuetoPushNotification
-KnownInterceptionDisclosureUITest.*
-LiveCaptionControllerTest.*
-LocalePolicyTest.*
-MediaSessionPictureInPictureWindowControllerBrowserTest.*
-MediaSessionVideoPictureInPictureWindowControllerBrowserTest.*
Expand Down
5 changes: 5 additions & 0 deletions test/filters/browser_tests.filter
Original file line number Diff line number Diff line change
Expand Up @@ -1802,6 +1802,11 @@
-ChromeLabsMultipleFeaturesUiTest.InvokeUi_default
-ChromeLabsUiTest.InvokeUi_default

# These tests fail because we stub captions::IsLiveCaptionFeatureSuppported to
# always return false
-LiveCaptionAutomaticLanguageDownloadTest.*
-LiveCaptionControllerTest.*

# Tests below this point have not been diagnosed or had issues created yet.
-_/WebrtcLoggingPrivateApiStartEventLoggingTestFeatureAndPolicyEnabled.*
-AccessCodeCastHandlerBrowserTest.*
Expand Down

0 comments on commit 186dfb9

Please sign in to comment.