Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scorer purpose #87

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Add scorer purpose #87

merged 5 commits into from
Aug 7, 2024

Conversation

ankrgyl
Copy link
Contributor

@ankrgyl ankrgyl commented Aug 4, 2024

This allows us to exclude LLM-as-a-judge calls from certain metrics (e.g. token counts)

@ankrgyl ankrgyl requested a review from manugoyal August 4, 2024 17:29
Copy link

github-actions bot commented Aug 4, 2024

Braintrust eval report

Autoevals (purpose-scorer-1722992568)

Score Average Improvements Regressions
NumericDiff 75.2% (+0pp) - -

Copy link

github-actions bot commented Aug 4, 2024

Braintrust eval report

Autoevals (purpose-scorer-1722792524)

Score Average Improvements Regressions
NumericDiff 75.2% (+0pp) - -

js/oai.ts Outdated
@@ -69,6 +72,7 @@ export function buildOpenAIClient(options: OpenAIAuth): OpenAI {
}

declare global {
// eslint-disable-next-line
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a more specific warning we can disable? or maybe a comment to explain what we are ignoring?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep added more specific one

@@ -18,7 +18,12 @@ class OpenAIWrapper:
RateLimitError: Exception


_WRAPPED_OPENAI = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid the global variable by returning this boolean as part of prepare_openai?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call

@ankrgyl ankrgyl merged commit 2c47406 into main Aug 7, 2024
8 checks passed
Copy link

github-actions bot commented Aug 7, 2024

Braintrust eval report

Autoevals (main-1722996118)

Score Average Improvements Regressions
NumericDiff 75.2% (+0pp) - -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants