Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schemas #21

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Update schemas #21

merged 2 commits into from
Aug 25, 2023

Conversation

smbea
Copy link
Contributor

@smbea smbea commented Aug 25, 2023

No description provided.

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Aug 25, 2023
@smbea smbea requested review from a team, marstamm, barmac and philippfromme and removed request for a team and barmac August 25, 2023 09:32
@smbea
Copy link
Contributor Author

smbea commented Aug 25, 2023

@marstamm @philippfromme could I get an approval here? Then I could make bpmn-io/bpmn-js-element-templates#14 ready for review before my FTO 🙂

@marstamm
Copy link
Contributor

Should we add a test case/expand existing test cases for this feature? (e.g. make one of the options optional: https://github.com/bpmn-io/element-templates-validator/blob/main/test/fixtures/multiple-connectors.json#L39)

@smbea
Copy link
Contributor Author

smbea commented Aug 25, 2023

@marstamm I added tests for it

Copy link
Contributor

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fake-join fake-join bot merged commit 8b55efe into main Aug 25, 2023
@fake-join fake-join bot deleted the update-schema branch August 25, 2023 12:36
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants