updata: fix fetching max version in remove-update #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When running the remove-update command it would report the max version available in the manifest. But it is checking the wrong order so that the latest version is not correctly reported. This is a simple fix for that. Signed-off-by: Yutong Sun <[email protected]>
yeazelm
reviewed
Jan 25, 2025
| @@ -118,7 +118,7 @@ impl RemoveUpdateArgs { | |||
| }); | |||
| // Note: We don't revert the maximum version on removal | |||
| update_metadata::write_file(&self.file, &manifest)?; | |||
| if let Some(current) = manifest.updates.first() { | |||
| if let Some(current) = manifest.updates.last() { | |||
There was a problem hiding this comment.
Is this just not sorted? I would expect to need to sort it to always get the max version?
There was a problem hiding this comment.
It is sorted in a reversed order. I will adjust the code to enforce a sort here so that we get deterministic result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes # N/A
Description of changes:
Testing done:
Before the fix:
After:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.