Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hypervisor framework compability for QEMU driver with --qemu-hvf flag #26

Merged
merged 1 commit into from
Nov 21, 2020
Merged

Conversation

leonsmith
Copy link
Contributor

Add in Hypervisor framework compability for QEMU driver with --qemu-hvf flag

@leonsmith
Copy link
Contributor Author

This resolved #10 but without adding in a new driver thanks to @tonyjames comments

@sycured
Copy link

sycured commented Jun 24, 2020

I tried your patch but it's not working… Compiled using master + your diff

1st try: podman-machine create box --driver qemu : no automatic detection… ok
2nd try: podman-machine create box --driver qemu --qemu-hvf : flag provided but not defined: -qemu-hvf

@sanshirookazaki
Copy link
Contributor

Hi @sycured It worked on my mac.
podman-machine create box --driver qemu --qemu-hvf

Can you see --qemu-hvf flag in the help text?
podman-machine create --driver qemu -h | grep qemu-hvf

@sycured
Copy link

sycured commented Aug 11, 2020

@sanshirookazaki no HVF on help output

@sanshirookazaki
Copy link
Contributor

@sycured
The built binary might not be in your path.
On my mac, it worked with the steps below

$ make
$ mv podman-machine /usr/local/bin/podman-machine
$ podman-machine create box --driver qemu --qemu-hvf

@sycured
Copy link

sycured commented Aug 12, 2020

I did with ./podman-machine

@afbjorklund
Copy link
Contributor

Sorry for leaving this up unattended

@afbjorklund afbjorklund merged commit 3a9bcd0 into boot2podman:master Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants