Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master develop icons #1601

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Master develop icons #1601

merged 2 commits into from
Jan 16, 2025

Conversation

daveoconnor
Copy link
Collaborator

This PR adds the links and icons for the master and develop branch on the libraries page.

Copy link
Member

@rbbeeston rbbeeston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with my code, and Dave's code looks good, but I'll defer to Greg

Copy link
Collaborator

@GregKaleka GregKaleka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

<div class="devmast_container">
<div class="mast_container" title="Master Branch">
<div class="minicircle mastercolor">M</div>
<a href="{% branch_url_tag request.resolver_match.view_name branch='master' kwargs=request.resolver_match.kwargs %}" class="giticon"><i class="fa-brands fa-git-alt fa-2xl"></i></a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a little cute, but I don't have any real concerns.

@daveoconnor daveoconnor merged commit fbec6ac into develop Jan 16, 2025
4 checks passed
@daveoconnor daveoconnor deleted the rbeeston/master-develop-icons branch January 16, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants