Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

News item-related fixes and improvements #1593

Merged
merged 4 commits into from
Jan 13, 2025
Merged

News item-related fixes and improvements #1593

merged 4 commits into from
Jan 13, 2025

Conversation

GregKaleka
Copy link
Collaborator

@GregKaleka GregKaleka commented Jan 10, 2025 •
edited
Loading

  • News item type icons added to homepage news
  • External links get external link icons
  • Avatars use our avatar tag, so they match styling of other avatars and link to the author's GitHub page

Screenshot 2025-01-13 at 10 40 01 AM

Fixes #1588

@GregKaleka GregKaleka requested a review from rbbeeston January 10, 2025 21:22
@rbbeeston
Copy link
Member

couple minor things:

  1. Make the icon for the type smaller
  2. Reverse the pic and the icon order.

Thanks!

@GregKaleka
Copy link
Collaborator Author

@rbbeeston see updated screenshot

rbbeeston
rbbeeston approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@rbbeeston rbbeeston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this. Thanks!

@GregKaleka GregKaleka merged commit 42b7877 into develop Jan 13, 2025
4 checks passed
@GregKaleka GregKaleka deleted the gk/issue-1588 branch January 13, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbbeeston rbbeeston rbbeeston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

News related updates
2 participants
@GregKaleka @rbbeeston