-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update styling in release report #1530
Conversation
brianjp93
commented
Dec 9, 2024
- fixes rework styling of release report #1527
730ad09
to
10436db
Compare
Let's make the logo a bit bigger so it matches the text height |
If we are going to put the logo on every subsequent page lets not also put the word Boost next to it |
10436db
to
c5056b1
Compare
Anyway this should be merged right away since it is an improvement. And we should keep refining. |
I disagree, mainly because if a screenshot is shared individually, both the logo and the name should be visible, in fact, perhaps it should also have the version number next to it, so context is there |
Jumping on Vinnie's slack comment, the avatars with the values under the names should be consistent and not use parentheses around the numbers, and give context next to them, as "235 Messages" or "12 commits" |
c5056b1
to
766393d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good with the latest changes, ok to merge