Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styling in release report #1530

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

brianjp93
Copy link
Collaborator

@brianjp93 brianjp93 requested a review from rbbeeston December 9, 2024 20:35
@brianjp93
Copy link
Collaborator Author

image
image
image
image
image

@rbbeeston
Copy link
Member

Let's make the logo a bit bigger so it matches the text height

@vinniefalco
Copy link
Member

If we are going to put the logo on every subsequent page lets not also put the word Boost next to it

@vinniefalco
Copy link
Member

Anyway this should be merged right away since it is an improvement. And we should keep refining.

@brianjp93
Copy link
Collaborator Author

Boost.pdf

@rbbeeston
Copy link
Member

If we are going to put the logo on every subsequent page lets not also put the word Boost next to it

I disagree, mainly because if a screenshot is shared individually, both the logo and the name should be visible, in fact, perhaps it should also have the version number next to it, so context is there

@rbbeeston
Copy link
Member

Jumping on Vinnie's slack comment, the avatars with the values under the names should be consistent and not use parentheses around the numbers, and give context next to them, as "235 Messages" or "12 commits"

Copy link
Member

@rbbeeston rbbeeston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with the latest changes, ok to merge

@brianjp93 brianjp93 merged commit 66eceba into boostorg:develop Dec 9, 2024
4 checks passed
@brianjp93 brianjp93 deleted the 1527-styling branch December 9, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rework styling of release report
3 participants