Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #166 negative precision #168

Merged
merged 7 commits into from
Feb 22, 2024
Merged

Fix for issue #166 negative precision #168

merged 7 commits into from
Feb 22, 2024

Conversation

mborland
Copy link
Member

@mborland mborland commented Feb 20, 2024

Partially Addresses: #166

Adds additional overloads to floating point to_chars to change the behavior based on unspecified vs negative precision

@mborland mborland changed the title Fix for issue #166 Fix for issue #166 negative precision Feb 20, 2024
@mborland mborland marked this pull request as ready for review February 20, 2024 11:01
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f5e1971) 92.30% compared to head (340a72e) 92.32%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #168      +/-   ##
===========================================
+ Coverage    92.30%   92.32%   +0.02%     
===========================================
  Files           64       65       +1     
  Lines         8316     8340      +24     
===========================================
+ Hits          7676     7700      +24     
  Misses         640      640              
Files Coverage Δ
include/boost/charconv/to_chars.hpp 100.00% <ø> (ø)
src/to_chars.cpp 93.44% <100.00%> (+0.85%) ⬆️
test/github_issue_166.cpp 100.00% <100.00%> (ø)
src/to_chars_float_impl.hpp 80.86% <89.65%> (+1.30%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5e1971...340a72e. Read the comment docs.

@mborland mborland merged commit 317e04f into develop Feb 22, 2024
59 checks passed
@mborland mborland deleted the 166.2 branch February 22, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant