Merge pull request #110 from bnb-chain/wenty/sorting

fix: Convert balance to number and then sorting
bnb-chain · Nov 8, 2024 · b3281e6 · b3281e6
2 parents a79bdd2 + d38a258
commit b3281e6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/canonical-bridge-widget/src/modules/aggregator/shared/sortTokens.ts b/packages/canonical-bridge-widget/src/modules/aggregator/shared/sortTokens.ts
@@ -52,13 +52,15 @@ export function sortTokens({
         return 1;
       }
 
-      if (a.balance && b.balance) {
+      const aBalance = Number(a.balance);
+      const bBalance = Number(b.balance);
+      if (aBalance && bBalance) {
         return sortWithPredefinedOrders();
       }
-      if (a.balance && !b.balance) {
+      if (aBalance && !bBalance) {
         return -1;
       }
-      if (!a.balance && b.balance) {
+      if (!aBalance && bBalance) {
         return 1;
       }
     }

diff --git a/packages/canonical-bridge-widget/src/modules/aggregator/types.ts b/packages/canonical-bridge-widget/src/modules/aggregator/types.ts
@@ -102,7 +102,7 @@ export interface IBridgeToken extends IBridgeTokenBaseInfo {
 }
 
 export interface IBridgeTokenWithBalance extends IBridgeToken {
-  balance?: number;
+  balance?: string;
   value?: number;
 }