Fix compiler errors when compiling for Arduino Nano 33 BLE platform #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the variables `D1` and `D2` to `D1_pres` and `D2_temp` to prevent conflict with `pins_arduino.h` when compiling for certain Arduino boards.
Add a cast to integer to prevent "ambiguous call" error
I notice there's a CI check which does pass, so I guess that's good? |
PaulZC
added a commit
to sparkfunX/BlueRobotics_MS5837_Library
that referenced
this pull request
Jan 27, 2021
PaulZC
added a commit
to sparkfunX/BlueRobotics_MS5837_Library
that referenced
this pull request
Jan 27, 2021
patrickelectric
pushed a commit
that referenced
this pull request
Mar 3, 2021
patrickelectric
pushed a commit
that referenced
this pull request
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My fix for #20.
I renamed a couple of variables
D1andD2as they were causing a conflict with certain Arduino headers for the Nano 33 BLE. I also added a cast-to-integer in some of the calls toWire::write, as the new mbed-based implementation ofWire.hprovides two candidates,write(uint8_t)andwrite(char*).I tried my best to make sure this code doesn't break anything else. I tried compiling for a few different Arduino platforms, including: Arduino Uno, Arduino Nano, Arduino Nano 33 BLE, Arduino Nano Every, Arduino Portenta H7, and Arduino Nano 33 IOT, and the library compiled without any issues. I apologise for not knowing the proper procedure to test my code thoroughly, I am a student and very new to this.