Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show what custom font is used #4024

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

intervinn
Copy link

Should be able to close #1345
I tried to just change the label's font family depending on selected font file. However, it could also be possible to change the entire label to the name of font (which would then likely lead to removal of translations for that button)

There might be issues, since I'm really new to .NET

image

@MrT-tak
Copy link

MrT-tak commented Dec 18, 2024

Huge if it works!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is your own font here...?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where else should it be

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nowhere? i dont think custom fonts should be bundled with bloxstrap

Copy link
Author

@intervinn intervinn Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your question is still unclear to me as the fonts are never bundled with bloxstrap itself; custom fonts are stored within appdata created AFTER bloxstrap installation, which is how i grab it and use within ui.

There might be issues, since I'm really new to .NET

THIS is the reason i've stated that there might be issues, as i struggled to find a clear way to process a font file into wpf

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, i just noticed what file did you actually comment on, my bad

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like the file remained after editing

@lokzz
Copy link

lokzz commented Dec 30, 2024

just incase & if you want, you can add it to the .gitignore file
to prevent accidently uploading a font file & then needing to delete it

@intervinn
Copy link
Author

yea, sounds good

@AskaLangly
Copy link

Sure, show the font, but what about showing the font used by name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] Show What Custom Font You Use (Bloxstrap Menu)
4 participants