Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mimetype guessing #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markunsworth
Copy link

@markunsworth markunsworth commented Jun 7, 2016

Have added the option to guess mimetypes when uploading files. Uses much the same logic as S3cmd, have not implemented mimemagic logic.

Uses the same flags as S3cmd.

-M or --guess-mime-type

Fixes #67

@kennu
Copy link

kennu commented Jul 31, 2016

This would be quite useful. I just broke my website by replacing aws s3 sync with s4cmd dsync, because it reset all the content types to application/octet-stream.

@markunsworth markunsworth force-pushed the mimetype-guessing branch 3 times, most recently from 04f9661 to bdd722c Compare August 2, 2016 13:39
@markunsworth
Copy link
Author

fixed up merge issues and reverted the formatting changes my IDE made

@schellj
Copy link

schellj commented Oct 8, 2016

I merged this branch into my fork and it seems to work fine. Very helpful for my project as I'm recursively pushing a large number of files from a directory and my site wouldn't work if I uploaded with s4cmd without specifying the mime type for each file individually.

@Epsiloncool
Copy link

It looks like this change was not yet applied. This is a reason why I still have to use old slow s3cmd.
May someone please apply mime-type guessing change?

Thanks.

@shapirus
Copy link

shapirus commented Sep 2, 2024

bump.
it's not possible to use s4cmd as a replacement for s3cmd for recursive uploads without this option.

@dmitry-sinina
Copy link

I have same problem - it is not possible to use s4cmd for static site content upload without this patch.

@shapirus
Copy link

I have same problem - it is not possible to use s4cmd for static site content upload without this patch.

as a workaround, you may want to check https://github.com/peak/s5cmd
that's what I ended up using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guessing of ContentType
6 participants