fix!: Search API functions how take query as a parameter #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandgorantala
approved these changes
Oct 22, 2024
The query to call the APIs with is a very dynamic (as in it changes a lot) value, as opposed to most of the other options which are more static. This change allows callers to call the function with the query as string, separate from the other options. It also allows for cleaner typing in consuming libraries with `ProductSearchOptions` as opposed to `Omit<ProductSearchOptions, 'q'>` when the query comes form some usually user generated state. BREAKING CHANGE: `productSearch`, `bestseller`, `contentSearch`, `categorySearch` and `autoSuggest` parameters have changed.
joerideg
force-pushed
the
search-options
branch
from
bf94157 to
8da1ea4
Compare
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query to call the APIs with is a very dynamic (as in it changes a lot) value, as opposed to most of the other options which are more static. This change allows callers to call the function with the query as string, separate from the other options. It also allows for cleaner typing in consuming libraries with
ProductSearchOptionsas opposed toOmit<ProductSearchOptions, 'q'>when the query comes form some usually user generated state.BREAKING CHANGE:
productSearch,bestseller,contentSearch,categorySearchandautoSuggestparameters have changed.