Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding an email when logging into merits #2369

Merged
merged 6 commits into from
Nov 7, 2024
Merged

Adding an email when logging into merits #2369

merged 6 commits into from
Nov 7, 2024

Conversation

maxaleks
Copy link
Contributor

@maxaleks maxaleks commented Nov 7, 2024 •
edited
Loading

Description and Related Issue(s)

Added an email step when logging into merits

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable
    • I updated the list of environment variables in the documentation
    • I made the necessary changes to the validator script according to the guide
    • I added "ENVs" label to this pull request

@maxaleks maxaleks requested a review from tom2drum November 7, 2024 09:15
@maxaleks maxaleks changed the base branch from main to release/v1-36-0 November 7, 2024 12:49
@maxaleks maxaleks merged commit a0deeab into release/v1-36-0 Nov 7, 2024
2 checks passed
@maxaleks maxaleks deleted the rewards-add-email branch November 7, 2024 13:48
tom2drum pushed a commit that referenced this pull request Nov 8, 2024
@maxaleks @tom2drum
Adding an email when logging into merits (#2369)
6a5ee48 
* add email step

* fix preset

* update text

* fix login with wallet

* update button text and var names

* update mixpanel events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom2drum tom2drum tom2drum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxaleks @tom2drum