Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MB-61889: support search with params #250

Merged
merged 3 commits into from
Jul 25, 2024
Merged

MB-61889: support search with params #250

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e979d30
MB-61889: support search with params
moshaad7 Jul 7, 2024
d792080
Upgrade to [email protected] & [email protected]
abhinavdangeti Jul 24, 2024
4cee9a2
Upgrade to blevesearch/[email protected]
abhinavdangeti Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions faiss_vector_posting.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package zap

import (
"encoding/binary"
"encoding/json"
"math"
"reflect"

Expand Down Expand Up @@ -266,14 +267,14 @@ func (vpl *VecPostingsIterator) BytesWritten() uint64 {

// vectorIndexWrapper conforms to scorch_segment_api's VectorIndex interface
type vectorIndexWrapper struct {
search func(qVector []float32, k int64) (segment.VecPostingsList, error)
search func(qVector []float32, k int64, params json.RawMessage) (segment.VecPostingsList, error)
close func()
size func() uint64
}

func (i *vectorIndexWrapper) Search(qVector []float32, k int64) (
func (i *vectorIndexWrapper) Search(qVector []float32, k int64, params json.RawMessage) (
segment.VecPostingsList, error) {
return i.search(qVector, k)
return i.search(qVector, k, params)
}

func (i *vectorIndexWrapper) Close() {
Expand All @@ -300,7 +301,7 @@ func (sb *SegmentBase) InterpretVectorIndex(field string, except *roaring.Bitmap

var (
wrapVecIndex = &vectorIndexWrapper{
search: func(qVector []float32, k int64) (segment.VecPostingsList, error) {
search: func(qVector []float32, k int64, params json.RawMessage) (segment.VecPostingsList, error) {
// 1. returned postings list (of type PostingsList) has two types of information - docNum and its score.
// 2. both the values can be represented using roaring bitmaps.
// 3. the Iterator (of type PostingsIterator) returned would operate in terms of VecPostings.
Expand All @@ -317,7 +318,7 @@ func (sb *SegmentBase) InterpretVectorIndex(field string, except *roaring.Bitmap
return rv, nil
}

scores, ids, err := vecIndex.SearchWithoutIDs(qVector, k, vectorIDsToExclude)
scores, ids, err := vecIndex.SearchWithoutIDs(qVector, k, vectorIDsToExclude, params)
if err != nil {
return nil, err
}
Expand Down
Loading