MB-62167: Fix windows crash #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
CascadingRadium
commented
Jun 5, 2024
•
CascadingRadium
commented
- Faiss does not support OnDiskInvertedLists on windows, and hence while using go-faiss's IO flags, we must take into account the build platform.
- This PR enforces the old faiss.IOFlagReadOnly flag for windows and maintains the existing io flags for unix based platforms.
abhinavdangeti
requested review from
abhinavdangeti,
Thejas-bhat,
metonymic-smokey,
Likith101 and
moshaad7
|
@CascadingRadium would you update the description here for our records. |
Thejas-bhat
reviewed
Jun 6, 2024
abhinavdangeti
approved these changes
Jun 6, 2024
moshaad7
pushed a commit
that referenced
this pull request
Sep 12, 2024
* MB-62167: Fix windows crash * vectorIndexIOFlags -> faissIOFlags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.