updating merge path with the ivf index creations #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavdangeti
commented
Oct 12, 2023
abhinavdangeti
commented
Oct 12, 2023
abhinavdangeti
commented
Oct 12, 2023
abhinavdangeti
requested review from
metonymic-smokey,
CascadingRadium,
Likith101,
moshaad7 and
Thejas-bhat
abhinavdangeti
commented
Oct 31, 2023
| @@ -211,6 +211,73 @@ func (v *vectorIndexOpaque) mergeAndWriteVectorIndexes(fieldID int, sbs []*Segme | |||
| vecIndexes = append(vecIndexes, index) | |||
| } | |||
|
|
|||
| if len(vecToDocID) > 10000 { | |||
There was a problem hiding this comment.
Should perhaps make this configurable?
If you chose 10000 only because faiss advertises the flat indexes perform well up until 10000 - I'm thinking if we should do some testing on our side to decide what a better value for this could be.
- bleve_index_api, - scorch_segment_api, - go_faiss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.