Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onClear event #10

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add onClear event #10

wants to merge 4 commits into from

Conversation

BesatZardosht
Copy link

It is nice to have onClear event callback

Copy link
Contributor

@sospedra sospedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙅‍♂️

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "react-signature-pad",
"version": "0.0.5",
"name": "react-signature-pad-component",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR hijacks the npm name, version and authority ⚠️

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! I didn't know I shouldn't change version and name. I send a merge request. So you can add onClear event in the original module

@Stenerson
Copy link

Can this be rebuilt and merged? It would be helpful use this callback, specifically for checking/resetting a parent's isEmpty state after a clear.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants