Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update defaults to match those used in the corresponding publication #35

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

huddlej
Copy link
Contributor

@huddlej huddlej commented Aug 19, 2024

Changes the defaults for pathogen-embed and pathogen-cluster to match the defaults we used in the corresponding "cartography" paper including:

  • changed encoding of alignment inputs for PCA embedding and t-SNE initialization by PCA from "integer" to "simplex"
  • changed minimum samples per cluster from 5 to 10

Changes the default encoding of alignment inputs for PCA embedding and
t-SNE initialization by PCA from "integer" to "simplex".
Changes min samples per cluster from 5 to 10 to match the defaults we
used in the corresponding publication.
@huddlej huddlej changed the title Use "simplex" encoding by default for PCA Update defaults to match those used in the corresponding publication Aug 19, 2024
@huddlej huddlej merged commit 5975884 into main Aug 19, 2024
4 checks passed
@huddlej huddlej deleted the simplex-as-pca-default branch August 19, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant