Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16926] Fix KM bad imports #12807

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

Thomas-Avery
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16926

📔 Objective

The purpose of this PR is to fix bad imports identified in #12744.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Thomas-Avery Thomas-Avery self-assigned this Jan 10, 2025
@@ -7,7 +7,7 @@ export { BiometricsCommands } from "./biometrics/biometrics-commands";
export { BiometricsService } from "./biometrics/biometric.service";
export * from "./biometrics/biometric.state";

export { KeyService } from "./abstractions/key.service";
export { KeyService, CipherDecryptionKeys } from "./abstractions/key.service";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to add CipherDecryptionKeys for the test file libs/common/src/vault/services/cipher.service.spec.ts

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Logo
Checkmarx One – Scan Summary & Detailsa1ef31e6-60ac-407a-9d9b-cdab1541f38c

New Issues (3)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /bitwarden_license/bit-web/src/app/tools/access-intelligence/critical-applications.component.html: 87
detailsMethod critical_applications_component at line 87 of /bitwarden_license/bit-web/src/app/tools/access-intelligence/critical-applications.component.h...
Attack Vector
MEDIUM Client_Privacy_Violation /bitwarden_license/bit-web/src/app/tools/access-intelligence/critical-applications.component.html: 82
detailsMethod critical_applications_component at line 82 of /bitwarden_license/bit-web/src/app/tools/access-intelligence/critical-applications.component.h...
Attack Vector
MEDIUM Missing_HSTS_Header /libs/common/src/services/api.service.ts: 230
detailsThe web-application does not define an HSTS header, leaving it vulnerable to attack.
Attack Vector

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.03%. Comparing base (1b9f546) to head (886411e).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
libs/key-management/src/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12807   +/-   ##
=======================================
  Coverage   35.03%   35.03%           
=======================================
  Files        2972     2972           
  Lines       90367    90367           
  Branches    16929    16929           
=======================================
  Hits        31659    31659           
  Misses      56253    56253           
  Partials     2455     2455           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thomas-Avery Thomas-Avery marked this pull request as ready for review January 10, 2025 19:10
@Thomas-Avery Thomas-Avery requested review from a team as code owners January 10, 2025 19:10
ike-kottlowski
ike-kottlowski previously approved these changes Jan 10, 2025
Copy link
Contributor

@ike-kottlowski ike-kottlowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auth changes good.

nick-livefront
nick-livefront previously approved these changes Jan 10, 2025
mzieniukbw
mzieniukbw previously approved these changes Jan 10, 2025
addisonbeck
addisonbeck previously approved these changes Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants