Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16895] Fix biometric prompt showing up in browser while disabled #12781

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Jan 9, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16895

📔 Objective

The biometrics service did not take into account the local settings from the biometricsstateservice to return the "NotEnabledLocally" status, and returned "desktopDisconnected" instead. The former should take priority so that the UI for biometrics gets hidden when the setting is disabled.

📸 Screenshots

Screen.Recording.2025-01-09.at.19.33.07.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten requested a review from a team as a code owner January 9, 2025 17:20
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Logo
Checkmarx One – Scan Summary & Details733a618d-7d3b-4440-93a6-868cbf90ca97

No New Or Fixed Issues Found

@quexten quexten force-pushed the km/fix-biometrics-browser-prompt branch from a27809e to d10baf8 Compare January 9, 2025 18:28
Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, but looks like we need to update the failing tests.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.14%. Comparing base (aec25b1) to head (2439e23).
Report is 37 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../lock/services/extension-lock-component.service.ts 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12781      +/-   ##
==========================================
- Coverage   34.14%   34.14%   -0.01%     
==========================================
  Files        2937     2937              
  Lines       90341    90419      +78     
  Branches    16964    16988      +24     
==========================================
+ Hits        30846    30870      +24     
- Misses      57040    57090      +50     
- Partials     2455     2459       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quexten quexten merged commit 5dc523b into main Jan 13, 2025
37 of 38 checks passed
@quexten quexten deleted the km/fix-biometrics-browser-prompt branch January 13, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants