Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase compile SDK to 35 #48

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Increase compile SDK to 35 #48

merged 1 commit into from
Oct 21, 2024

Conversation

ArnyminerZ
Copy link
Member

No description provided.

@ArnyminerZ
Increase compile SDK to 35
075643a 
Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ ArnyminerZ added the refactoring Quality improvement of existing functions label Oct 21, 2024
@ArnyminerZ ArnyminerZ self-assigned this Oct 21, 2024
@ArnyminerZ ArnyminerZ requested a review from rfc2822 October 21, 2024 08:45
@rfc2822
Copy link
Member

rfc2822 commented Oct 21, 2024

Is there a good reason to do so in vcard4android?

Otherwise I'd just increase in davx5

@ArnyminerZ
Copy link
Member Author

Is there a good reason to do so in vcard4android?

Well, no reason at all, but Google says:

You should generally use the most up-to-date API level available. If you are planning to also support older API levels, it's good practice to use the Lint tool to check if you are using APIs that are not available in earlier API levels.

So actually there shouldn't be any issues on lower SDK levels, since we are not upgrading the minSdkVersion, we are just sort of saying that the library is compatible with SDK 35, and I think it would compile using the latest SDK and platform tools.

rfc2822
rfc2822 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, of course, you're right, I thought it was the min sdk level

@rfc2822 rfc2822 merged commit 13840ad into main Oct 21, 2024
5 checks passed
@rfc2822 rfc2822 deleted the compile-sdk branch October 21, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfc2822 rfc2822 rfc2822 approved these changes

Assignees

@ArnyminerZ ArnyminerZ

Labels
refactoring Quality improvement of existing functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArnyminerZ @rfc2822