Birthdays not synced from Nextcloud 27 to Android 12/13

[ArnyminerZ]

No description provided.

[rfc2822]

Seems that the vCard 3 and 4 RFCs don't allow ZonedDateTime, so I have removed it and added a warning for unknown types.

Also added the BDAY to the "all fields" test so that we can be sure that it's actually interpreted correctly. This test would detect the problem we had (for instance if OffsetDateTime would again be wrong).

[devvv4ever]

Shouldn't this fix be included in 4.3.10? @rfc2822 @ArnyminerZ

It seems we didn't include the latest vcard4android version in the latest DAVx5 (4.3.10). Maybe we forgot to update. Can we please use the latest vcard4android in 4.3.11 so that the parsing finally works for the reported birthday in #24 and bitfireAT/davx5-ose#385

Or maybe there is a reason for not using the latest vcard4android (any blocker)?

[fwiep]

Hello again, using v4.3.12.1-ose in my local timezone (Europe/Amsterdam).

The birthdays now do sync, but seem off by one day. For example, the VCARD has a BDAY-property of 19730928T000000+0100. After syncing with DAVx5, in the Android contacts app, this shows as 27 september 1973.

Could this (still) be timezone related? Should a separate issue be created for this?

Kind regards,
FWieP

[rfc2822]

As far as I know, the Contacts storage doesn't support time zones and always requires UTC.

So vcard4android stores the date/time as UTC:

vcard4android/lib/src/main/java/at/bitfire/vcard4android/contactrow/EventBuilder.kt

Lines 75 to 77 in a7a1f42

	// time zones not supported by Contacts storage, convert to UTC
	val utc = date.atZoneSameInstant(ZoneOffset.UTC)
	DateTimeFormatter.ofPattern(DATE_AND_TIME_FORMAT, Locale.US).format(utc)

19730928T000000+0100 is 27 Sep 1973 23:00 UTC. So the birth at exactly midnight local time actually happened on 27 Sep 1973 UTC.

If your contacts app shows another time, it probably doesn't handle the UTC correctly (it should at least indicate that it is UTC or convert to the current device time zone).

[fwiep]

As far as I know, the Contacts storage doesn't support time zones and always requires UTC.
So vcard4android stores the date/time as UTC:
...
If your contacts app shows another time, it probably doesn't handle the UTC correctly (it should at least indicate that it is UTC or convert to the current device time zone).

Case solved thanks to this comment.

I compared the datetimes in both my source application and the Nextcloud instance. The first was stored without timezone information (MariaDB DATETIME), the latter inside the VCard's BDAY: 19730928T000000+0100, synced from my source application using Sabre\VObject\Component\VCard. Once I forced these datetimes to UTC, all is well and Android Contacts shows the correct birthdays.

Thank you very much!
FWieP

[rfc2822]

Good that it now works. I'd still specify it as a date (without time), if there's no time available, and 00:00:00 indicates this case. Dates (without time) don't have timezones and don't cause such problems.