Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Commons dependency #369

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Removed Commons dependency #369

merged 5 commits into from
Jul 29, 2024

Conversation

ArnyminerZ
Copy link
Member

@ArnyminerZ ArnyminerZ commented Jul 20, 2024 •
edited
Loading

Purpose

Removes the need of Apache Commons

Depends on bitfireAT/ical4android#156

Short description

  • Upgrade all of our dependencies that depend on commons (ical4android)
  • Get rid of Commons dependency.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@ArnyminerZ
Removed Commons dependency
7e7558c 
Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ ArnyminerZ added the refactoring Quality improvement of existing functions label Jul 20, 2024
@ArnyminerZ ArnyminerZ self-assigned this Jul 20, 2024
@ArnyminerZ ArnyminerZ linked an issue Jul 20, 2024 that may be closed by this pull request
Get rid of Apache Commons #367
Closed
@ArnyminerZ ArnyminerZ marked this pull request as draft July 20, 2024 08:48
@github-actions github-actions bot added dependent Depends on other issues/PRs and removed dependent Depends on other issues/PRs labels Jul 20, 2024
@github-actions GitHub Actions
Copy link

This PR/issue depends on:

@ArnyminerZ ArnyminerZ marked this pull request as ready for review July 22, 2024 11:27
@ArnyminerZ ArnyminerZ requested a review from sunkup July 22, 2024 11:27
sunkup
sunkup previously approved these changes Jul 29, 2024
View reviewed changes
@sunkup sunkup merged commit 21919b3 into dev Jul 29, 2024
7 checks passed
@sunkup sunkup deleted the 367-get-rid-of-commons branch July 29, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunkup sunkup sunkup left review comments

Assignees

@ArnyminerZ ArnyminerZ

Labels
refactoring Quality improvement of existing functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of Apache Commons
2 participants
@ArnyminerZ @sunkup