fixed the way of building apps with any disired config #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit of the previous PR is : df96c57 Again sorry and have a nice week-end ! |
|
alright, so what I understand from your comments, your issue with the current way is that the oot/app layer can only be build with the default config (CF2) and not with bolt config? Also, tt is probably best to add at least the comments to the docs of the app layer instead of the .mk file for more visibility: https://github.com/bitcraze/crazyflie-firmware/edit/master/docs/userguides/app_layer.md |
|
Fixed with #1398 - correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
First, I am deeply sorry as i misunderstood the way building an app works. So the way of building an app, previously proposed from a PR, wasn't able to do the job it was supposed to, but didn't compromise the way of doing so that was already in place.
Using the previous Makefile file with CONFIG="" only compiled the firmware and not the app !
The modifications here are comments explaining the difference of building the apps.
the all rule allow to build an app with any config (eg. bolt) BUT requires the config file to be already included in the app-config file.
This might or not be desired.
In case not, the any rule concats the desired config file in a tmp oot-config file (eg. bolt_defconfig) before the app-config file
THEN calls the all rule.
NB. Binary files are also present in the app filesystem after compiling (*.o and *.o.cmd) (they were already from legacy) that are not caught by the clean rule. But that's not the subject of this PR.