Skip to content

Commit

Permalink
Stop using disarming as an alternative emergency stop / crashed state…
Browse files Browse the repository at this point in the history
… trigger.

If you try to disarm before landing has been registered, this will no longer trigger an emergency stop and the resulting system lock. Fixes #1425.
  • Loading branch information
gemenerik committed Oct 17, 2024
1 parent a39b193 commit 13f16ff
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/modules/src/supervisor_state_machine.c
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ static SupervisorStateTransition_t transitionsFlying[] = {
.newState = supervisorStateExceptFreeFall,

.triggers = SUPERVISOR_CB_COMMANDER_WDT_TIMEOUT | SUPERVISOR_CB_EMERGENCY_STOP,
.negatedTriggers = SUPERVISOR_CB_ARMED,
.negatedTriggers = SUPERVISOR_CB_NONE,
.triggerCombiner = supervisorAny,

.blockerCombiner = supervisorNever,
Expand All @@ -169,7 +169,7 @@ static SupervisorStateTransition_t transitionsFlying[] = {
.newState = supervisorStateCrashed,

.triggers = SUPERVISOR_CB_IS_TUMBLED,
.negatedTriggers = SUPERVISOR_CB_ARMED,
.negatedTriggers = SUPERVISOR_CB_NONE,
.triggerCombiner = supervisorAny,

.blockerCombiner = supervisorNever,
Expand Down Expand Up @@ -230,7 +230,7 @@ static SupervisorStateTransition_t transitionsWarningLevelOut[] = {
.newState = supervisorStateExceptFreeFall,

.triggers = SUPERVISOR_CB_COMMANDER_WDT_TIMEOUT | SUPERVISOR_CB_IS_TUMBLED | SUPERVISOR_CB_EMERGENCY_STOP,
.negatedTriggers = SUPERVISOR_CB_ARMED,
.negatedTriggers = SUPERVISOR_CB_NONE,
.triggerCombiner = supervisorAny,

.blockerCombiner = supervisorNever,
Expand Down

0 comments on commit 13f16ff

Please sign in to comment.